Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] K8s support query replicas #3234

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[ENH] K8s support query replicas #3234

merged 2 commits into from
Dec 3, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Dec 3, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • K8s support for replicas on the query node
  • New functionality
    • None

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB merged commit 19eb065 into main Dec 3, 2024
71 checks passed
@HammadB HammadB mentioned this pull request Dec 4, 2024
Merged
1 task
HammadB added a commit that referenced this pull request Dec 4, 2024
@HammadB
[CHORE] Bump helm chart version (#3239)
038405e 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
   - Helm chart version needs to be bumped after #3234 
 - New functionality
   - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HammadB